From 2ead25d190eca3fda886ae3fd9ad07681c0e843f Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 20 Feb 2026 12:51:09 +0100 Subject: [PATCH 1/2] tools: avoid building twice in coverage jobs --- .github/workflows/coverage-linux-without-intl.yml | 6 +++--- .github/workflows/coverage-linux.yml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/coverage-linux-without-intl.yml b/.github/workflows/coverage-linux-without-intl.yml index 64f8fe1ff3161e..4f33cde52d4883 100644 --- a/.github/workflows/coverage-linux-without-intl.yml +++ b/.github/workflows/coverage-linux-without-intl.yml @@ -71,11 +71,11 @@ jobs: run: npx envinfo - name: Install gcovr run: pip install gcovr==7.2 - - name: Build - run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage --without-intl" + - name: Configure + run: ./configure -v --error-on-warn --coverage --without-intl # TODO(bcoe): fix the couple tests that fail with the inspector enabled. # The cause is most likely coverage's use of the inspector. - - name: Test + - name: Build and test run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0 - name: Report JS run: npx c8 report --check-coverage diff --git a/.github/workflows/coverage-linux.yml b/.github/workflows/coverage-linux.yml index 666f0568f4c4b7..0eb8f6ae3e6818 100644 --- a/.github/workflows/coverage-linux.yml +++ b/.github/workflows/coverage-linux.yml @@ -71,11 +71,11 @@ jobs: run: npx envinfo - name: Install gcovr run: pip install gcovr==7.2 - - name: Build - run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage" + - name: Configure + run: ./configure -v --error-on-warn --coverage # TODO(bcoe): fix the couple tests that fail with the inspector enabled. # The cause is most likely coverage's use of the inspector. - - name: Test + - name: Build and test run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0 - name: Report JS run: npx c8 report --check-coverage From 5ee426d4ad820f489c58251d14c506902e9d009a Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 20 Feb 2026 12:56:07 +0100 Subject: [PATCH 2/2] fixup! tools: avoid building twice in coverage jobs --- .github/workflows/coverage-linux-without-intl.yml | 2 +- .github/workflows/coverage-linux.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverage-linux-without-intl.yml b/.github/workflows/coverage-linux-without-intl.yml index 4f33cde52d4883..feb4021c2ecafe 100644 --- a/.github/workflows/coverage-linux-without-intl.yml +++ b/.github/workflows/coverage-linux-without-intl.yml @@ -72,7 +72,7 @@ jobs: - name: Install gcovr run: pip install gcovr==7.2 - name: Configure - run: ./configure -v --error-on-warn --coverage --without-intl + run: ./configure --verbose --error-on-warn --coverage --without-intl # TODO(bcoe): fix the couple tests that fail with the inspector enabled. # The cause is most likely coverage's use of the inspector. - name: Build and test diff --git a/.github/workflows/coverage-linux.yml b/.github/workflows/coverage-linux.yml index 0eb8f6ae3e6818..9a961f5588946b 100644 --- a/.github/workflows/coverage-linux.yml +++ b/.github/workflows/coverage-linux.yml @@ -72,7 +72,7 @@ jobs: - name: Install gcovr run: pip install gcovr==7.2 - name: Configure - run: ./configure -v --error-on-warn --coverage + run: ./configure --verbose --error-on-warn --coverage # TODO(bcoe): fix the couple tests that fail with the inspector enabled. # The cause is most likely coverage's use of the inspector. - name: Build and test