moved gunicorn config out of dockerfile args#477
Merged
Conversation
Now you can just run it with `gunicorn`
tallen42
force-pushed
the
move-gunicorn-config
branch
from
d51a634 to
38adee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the gunicorn config out of dockerfile so you can just run it with
gunicornWhy
Having it all in the dockerfile was cumbersome and maybe I'm thinking about a better way to do datadog in our flask apps and this makes it so much easier
Test Plan
Ran dockerfile with updated arguements as well as just
gunicornin a venvEnv Vars
Yes, added (well renamed)
WEB_CONCURRENCYtoCONDITIONAL_WORKERSChecklist