Skip to content

Comments

Light grid-related cleanup#1898

Open
slipher wants to merge 8 commits intoDaemonEngine:masterfrom
slipher:grid-cleanup
Open

Light grid-related cleanup#1898
slipher wants to merge 8 commits intoDaemonEngine:masterfrom
slipher:grid-cleanup

Conversation

@slipher
Copy link
Member

@slipher slipher commented Feb 16, 2026

A few light grid-related cleanups/optimizations that do not change the functionality.

@slipher slipher force-pushed the grid-cleanup branch 2 times, most recently from 001106f to 842c8b1 Compare February 17, 2026 09:07
@slipher
Copy link
Member Author

slipher commented Feb 17, 2026

Added some more commits. I fixed a funny bug with r_showLightGrid. Due to this visualization, I thought for a long time that it is possible for the ambient and the directed light colors to be different. In fact, they are always the same color, just with different brightness levels. (There are distinct colors in the BSP, but in Daemon's post-processing they are just averaged...) But due to buggy float-to-byte color conversion, r_showLightGrid sometimes rendered different colors, e.g. blue directed and red ambient.

@slipher slipher force-pushed the grid-cleanup branch 2 times, most recently from 586a547 to 038043c Compare February 20, 2026 10:36
@VReaperV
Copy link
Contributor

VReaperV commented Feb 20, 2026

Don't store alpha channel for lightGrid2 image doesn't really do anything as drivers generally don't implement RGB formats and will instead convert it to RGBA.

@slipher
Copy link
Member Author

slipher commented Feb 21, 2026

Don't store alpha channel for lightGrid2 image doesn't really do anything as drivers generally don't implement RGB formats and will instead convert it to RGBA.

Thanks for the info. I think I'll keep the commit since it doesn't make the code any longer, and if nothing else it serves the documentational purpose of showing that only 3 channels are use in /listimages. But I removed the comment saying why we should use 255 instead of 1 since it is unimportant.

@slipher
R_LoadLightGrid: comment suspicious-looking things
18d36f2 
Also fix reversed naming of lat/long and fix wrong comments.
@slipher
Don't lose precision while linearizing light grid
5edea21 
In one step of light grid processing, values were converted from sRGB to
linear and stored in bytes. This unnecessarily loses precision during
the calculation.
@slipher
Don't store alpha channel for lightGrid2 image
4357174 
Set the alpha byte to 255 so the image uploading code will choose an RGB
format.
@slipher
Don't create lightGrid2 image if deluxe disabled
5b3dd5d 
Don't create the light grid direction image if deluxe mapping is
disabled.
@slipher
R_LoadLightGrid: simplify code for skipping 0 points
3c11bfd
@slipher
Fix wrong default light grid (when BSP lacks one)
fa6d967 
The direction vector encoding was wrong.
@slipher
r_showLightGrid: fix wrong colors displayed
fc023da 
Sometimes color values were slightly greater than 1; this led to
an incorrect float color -> byte color conversion. Fix it by
clamping the colors in Tess_AddTetrahedron.
@slipher
r_showLightGrid: access grid values directly
3f78683 
Don't use R_LightForPoint which has some levels of tweaking and
interpolation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slipher @VReaperV