Try to limit darkening caused by bad deluxe maps#1907
Draft
slipher wants to merge 1 commit intoDaemonEngine:masterfrom
Draft
Try to limit darkening caused by bad deluxe maps#1907slipher wants to merge 1 commit intoDaemonEngine:masterfrom
slipher wants to merge 1 commit intoDaemonEngine:masterfrom
Conversation
Member
Author
|
Well, #1905 seems to be caused by a DarkPlaces file format incompatibility, so we don't need to fix that in the deluxe mapping code. On the other hand, if this only happens in some Unvanquished maps, there aren't a ton of legacy maps with normal mapping out there, and I believe illwieckz figured out how to fix in the map source. So maybe this code is unneeded since we can just fix the maps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1905 and Unvanquished/Unvanquished#2908. This is able to fix the Station 15 case, which has perfectly smooth windows and mostly smooth nearby affected walls/ceilings. It's not able to help much on the Xonotic case (even if I crank the maximum angle way down) because it has super bumpy normal maps, so the angle change can't be limited much.