Draft
Conversation
used `pnpm turbo gen`
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
TODO: look into moving this into some other package. IMO: `scripts`
Added jsdocs from chat too. not sure if they're accurate
…tHacks/forge into utils/create-utils-package
Contributor
Author
|
@DGoel1602 can you do |
Made console an eslint error not warn. This forces us to actually choose when to use console, when to use logger, and when to do nothing. We still need to look into actually handling errors on the frontend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
As discussed in #340, we have a bunch of utils that need to be consolidated into one package.
What
Resolves: #340
We are moving things to this package. Namely:
@forge/api/src/utils.ts)Test Plan
TBD
Checklist
TBD
db:pushbefore merging