[PHP] Always prefer host config over static servers from OpenAPI declaration#23017
Open
stollr wants to merge 1 commit intoOpenAPITools:masterfrom
Open
[PHP] Always prefer host config over static servers from OpenAPI declaration#23017stollr wants to merge 1 commit intoOpenAPITools:masterfrom
stollr wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
…aration Currently the host in the config object is ignored if an operation declares its own `servers` in the OpenAPI file, which makes it impossible to override it in the application. Fixes OpenAPITools#23016
Author
|
After looking over the api class behaviour regarding the default hosts config once again, I realize that my solution could be problematic if specific operations have different server declarations than the rest and would lead to backward incompatibility. So if anybody has an idea to improve this, you are welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug described in #23016.
Currently the host in the config object is ignored if an operation declares its own
serversin the OpenAPI file, which makes it impossible to override it in the application.With this change, the host, defined in the config, always has priority over the servers declared in the operation.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)
Summary by cubic
Always use the config host for PHP PSR-18 clients, even when an operation defines its own servers, so apps can override OpenAPI-declared hosts. Fixes #23016.
Written for commit 195abcf. Summary will update on new commits.