fix(query-core): decouple timers, retry and gc defaults from isServer guard#10153
Open
grzdev wants to merge 1 commit intoTanStack:mainfrom
Open
fix(query-core): decouple timers, retry and gc defaults from isServer guard#10153grzdev wants to merge 1 commit intoTanStack:mainfrom
grzdev wants to merge 1 commit intoTanStack:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10139
Problem
isServer(typeof window === 'undefined' || 'Deno' in globalThis) is used to gate runtime features like:This incorrectly disables those features in windowless client environments
(e.g. VSCode extensions, Chrome extensions, Electron, Workers), which are not SSR
but do not define
window.As a result:
refetchIntervaldoes not runstaleTimedoes not flip to staleretrybecomes0gcTimebecomesInfinityFix
Remove
isServerguards from runtime paths that are only created viaclient-side subscriptions (effects /
useSyncExternalStore),so they never execute during SSR anyway.
Changes:
queryObserver.tsisServerfrom#updateStaleTimeout()isServerfrom#updateRefetchInterval()retryer.tsretryto3unconditionally instead ofisServer ? 0 : 3removable.tsgcTimeto5 * 60 * 1000unconditionally instead ofisServer ? Infinity : 5 * 60 * 1000Not modified:
focusManager.tsonlineManager.tsThose
isServerchecks guardwindow.addEventListenerusage and are correct.Tests
Added tests proving behavior in a
window-undefined environment:windowis undefinedisStale3All new tests pass.