Add problem 108 of project euler by indigo0445 · Pull Request #14297 · TheAlgorithms/Python

indigo0445 · 2026-02-21T10:38:03Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2026-02-21T10:38:58Z

project_euler/problem_108/sol1.py

+"""
+
+
+def find_primes(n : int) -> list[int]:


Please provide descriptive name for the parameter: n

algorithms-keeper · 2026-02-21T10:38:58Z

project_euler/problem_108/sol1.py

+    return [i for i in range(2, n + 1) if sieve[i]]
+
+
+def find_prime_factorizations(n : int) -> list[dict[int, int]]:


Please provide descriptive name for the parameter: n

algorithms-keeper · 2026-02-21T10:38:58Z

project_euler/problem_108/sol1.py

+    upper_bound = 210 ** ((int((2 * target - 1) ** 0.25) + 1) // 2)
+    prime_factorizations = find_prime_factorizations(upper_bound)
+
+    def num_solutions(n):


Please provide return type hint for the function: num_solutions. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file project_euler/problem_108/sol1.py, please provide doctest for the function num_solutions

Please provide type hint for the parameter: n

Please provide descriptive name for the parameter: n

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2026-02-21T10:45:30Z

project_euler/problem_108/sol1.py

+"""
+
+
+def find_primes(n: int) -> list[int]:


Please provide descriptive name for the parameter: n

algorithms-keeper · 2026-02-21T10:45:30Z

project_euler/problem_108/sol1.py

+    return [i for i in range(2, n + 1) if sieve[i]]
+
+
+def find_prime_factorizations(n: int) -> list[dict[int, int]]:


Please provide descriptive name for the parameter: n

algorithms-keeper · 2026-02-21T10:45:30Z

project_euler/problem_108/sol1.py

+    upper_bound = 210 ** ((int((2 * target - 1) ** 0.25) + 1) // 2)
+    prime_factorizations = find_prime_factorizations(upper_bound)
+
+    def num_solutions(n):


Please provide return type hint for the function: num_solutions. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file project_euler/problem_108/sol1.py, please provide doctest for the function num_solutions

Please provide type hint for the parameter: n

Please provide descriptive name for the parameter: n

for more information, see https://pre-commit.ci

indigo0445 and others added 2 commits February 21, 2026 05:30

Add problem 108 of project euler

bbfabe1

[pre-commit.ci] auto fixes from pre-commit.com hooks

c89ecc8

for more information, see https://pre-commit.ci

algorithms-keeper bot reviewed Feb 21, 2026

View reviewed changes

fix ruff check

7c648a6

algorithms-keeper bot reviewed Feb 21, 2026

View reviewed changes

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Feb 21, 2026

follow conventions

2226db4

algorithms-keeper bot removed require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Feb 21, 2026

indigo0445 and others added 2 commits February 21, 2026 06:07

fix ruffs

b4703f7

[pre-commit.ci] auto fixes from pre-commit.com hooks

09ffcc8

for more information, see https://pre-commit.ci

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Add problem 108 of project euler#14297

Add problem 108 of project euler#14297
indigo0445 wants to merge 6 commits intoTheAlgorithms:masterfrom
indigo0445:euler_108

indigo0445 commented Feb 21, 2026

Uh oh!

algorithms-keeper bot left a comment

Uh oh!

algorithms-keeper bot Feb 21, 2026

Uh oh!

algorithms-keeper bot Feb 21, 2026

Uh oh!

algorithms-keeper bot Feb 21, 2026

Uh oh!

algorithms-keeper bot left a comment

Uh oh!

algorithms-keeper bot Feb 21, 2026

Uh oh!

algorithms-keeper bot Feb 21, 2026

Uh oh!

algorithms-keeper bot Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		return [i for i in range(2, n + 1) if sieve[i]]


		def find_prime_factorizations(n : int) -> list[dict[int, int]]:

		return [i for i in range(2, n + 1) if sieve[i]]


		def find_prime_factorizations(n: int) -> list[dict[int, int]]:

Uh oh!

Comments

Conversation

indigo0445 commented Feb 21, 2026

Describe your change:

Checklist:

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant