Update PR comment behavior for on-failure mode#941
Open
sgmurphy wants to merge 2 commits intoactions:mainfrom
Open
Update PR comment behavior for on-failure mode#941sgmurphy wants to merge 2 commits intoactions:mainfrom
on-failure mode#941sgmurphy wants to merge 2 commits intoactions:mainfrom
Conversation
When comment_summary_in_pr is set to 'on-failure', the action now updates existing comments when issues are resolved in subsequent runs, providing clear feedback that dependency issues have been fixed.
sgmurphy
force-pushed
the
update-pr-comment
branch
from
fb6f77d to
f21eb50
Compare
Contributor
Author
|
Hey @dangoor 👋 , any chance I could get a review 👀 on this? |
|
👋 This pull request has been marked as stale because it has been open with no activity for 180 days. You can: comment on the PR or remove the stale label to hold stalebot off for a while, add the |
|
This is still very important to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on-failuremode to update existing comments when issues are resolvedChanges
comment-pr.tsto handle success cases in on-failure mode by updating existing commentshasExistingCommenthelper function to check for existing dependency review commentsTest plan
Demo
Live demonstration of the enhanced functionality:
Demo 1: Enhanced
on-failuremode behaviorsgmurphy/fictional-garbanzo#1
on-failuremodeDemo 2:
nevermode validationsgmurphy/fictional-garbanzo#2
comment-summary-in-pr: neverproperly suppresses all comments