feat: add api shape field to allow distinction between api formats beyond sdk type#14487
Open
rekram1-node wants to merge 2 commits intodevfrom
Open
feat: add api shape field to allow distinction between api formats beyond sdk type#14487rekram1-node wants to merge 2 commits intodevfrom
rekram1-node wants to merge 2 commits intodevfrom
Conversation
rekram1-node
changed the title
Contributor
|
Was thinking about this, would it be okay to completely make two providers as we do have one for Azure OpenAI, and in models.dev only add models that support responses api (open ai models), then on the other one Azure Cognitive Services its going to be predominantly for the completion models? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a wip, but the idea here is some models on azure for instance only support the completions api and not responses.
We had poor code to distinguish this, the idea here is to update models.dev to allow things like:
[provider]
shape = completions
We should prolly change shape from an enum to a string to prevent new shapes on models.dev from breaking old oc versions