chore: update version of dependency lua-casbin to 1.46.0#12985
Open
rg2011 wants to merge 1 commit intoapache:masterfrom
Open
chore: update version of dependency lua-casbin to 1.46.0#12985rg2011 wants to merge 1 commit intoapache:masterfrom
rg2011 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Hi @rg2011, can you create a test based on the scenario described in the issue? We want to verify that the issue is fixed and prevent similar issues from occurring again in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
lua-casbinmodule dependency to version1.46.0, to fix a bug that was reported upstream (casbin/lua-casbin#152).Which issue(s) this PR fixes:
Fixes #12974
Checklist
I haven't updated tests or documentation because I don't know if it applies to dependency bumps, it there is some doc to update please let me know.
Regarding backward compatibility, the only difference between the current lua-casbin version (
1.45.0) and the new one (1.46.0) is the fix to bug casbin/lua-casbin#152:https://github.com/casbin/lua-casbin/compare/v1.45.0..v1.46.0
So I believe there are no backward compatibility issues, but have not tested extensively.