fix: fix misspelled variable, missing format arg, and wrong pointer assignment#570
Merged
wgtmac merged 1 commit intoapache:mainfrom Feb 22, 2026
Merged
Conversation
…ssignment
- Rename `while_digits` to `whole_digits` in decimal parser (typo)
- Add missing `{}` format placeholder in parquet writer error message
- Fix `batch = nullptr` to `*batch = nullptr` in EmptyRecordBatchReader
zhjwpku
approved these changes
Feb 22, 2026
|
|
||
| struct DecimalComponents { | ||
| std::string_view while_digits; | ||
| std::string_view whole_digits; |
Collaborator
There was a problem hiding this comment.
Yes, that was an oversight while copying from Arrow's code[1].
wgtmac
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
while_digitstowhole_digitsin decimal parser (typo for "whole" digits, the integer part before the decimal point){}format placeholder in parquet writer error message so the codec name is actually includedbatch = nullptrto*batch = nullptrinEmptyRecordBatchReader::ReadNext()so the caller's shared_ptr is properly clearedTest plan
expression_test,util_test,parquet_test)