[SPARK-51834][SQL][FOLLOW-UP][4.1] Add missing .withConstraints() in AtomicReplaceTableExec#54404
Open
yyanyy wants to merge 1 commit intoapache:branch-4.1from
Open
Conversation
…omicReplaceTableExec` ### What changes were proposed in this pull request? SPARK-51834 added `.withConstraints()` to `CreateTableExec` and `ReplaceTableExec` but missed `AtomicReplaceTableExec` in the same file. This causes `REPLACE TABLE` and `CREATE OR REPLACE TABLE` with constraints to silently drop them when the catalog implements `StagingTableCatalog`. Also fixes `StagingInMemoryTableCatalog` to forward constraints when constructing `InMemoryTable`, and adds regression tests for all four constraint types through the atomic replace path. ### Why are the changes needed? `AtomicReplaceTableExec` does not call `.withConstraints()` when building `TableInfo`, so `REPLACE TABLE` and `CREATE OR REPLACE TABLE` silently drop constraints when the catalog implements `StagingTableCatalog`. ### Does this PR introduce _any_ user-facing change? Yes. Previously, REPLACE TABLE and CREATE OR REPLACE TABLE with constraints would silently drop constraints when using a `StagingTableCatalog`. After this fix, constraints are correctly passed through to the catalog. ### How was this patch tested? New unit tests in `UniqueConstraintSuite`, `PrimaryKeyConstraintSuite`, `CheckConstraintSuite`, and `ForeignKeyConstraintSuite` that exercise `REPLACE TABLE` with constraints through the atomic catalog path (`StagingInMemoryTableCatalog`). Verified that all 4 new tests fail without the fix and pass with it. All existing tests in these suites continue to pass. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.6 <noreplyanthropic.com> Closes apache#54322 from yyanyy/staging_catalog_constraint. Authored-by: Yan Yan <yyanyyyy@gmail.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
pan3793
changed the title
.withConstraints() in AtomicReplaceTableExec.withConstraints() in AtomicReplaceTableExec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is to backport #54322)
What changes were proposed in this pull request?
SPARK-51834 added
.withConstraints()toCreateTableExecandReplaceTableExecbut missedAtomicReplaceTableExecin the same file. This causesREPLACE TABLEandCREATE OR REPLACE TABLEwith constraints to silently drop them when the catalog implementsStagingTableCatalog.Also fixes
StagingInMemoryTableCatalogto forward constraints when constructingInMemoryTable, and adds regression tests for all four constraint types through the atomic replace path.Why are the changes needed?
AtomicReplaceTableExecdoes not call.withConstraints()when buildingTableInfo, soREPLACE TABLEandCREATE OR REPLACE TABLEsilently drop constraints when the catalog implementsStagingTableCatalog.Does this PR introduce any user-facing change?
Yes. Previously, REPLACE TABLE and CREATE OR REPLACE TABLE with constraints would silently drop constraints when using a
StagingTableCatalog. After this fix, constraints are correctly passed through to the catalog.How was this patch tested?
New unit tests in
UniqueConstraintSuite,PrimaryKeyConstraintSuite,CheckConstraintSuite, andForeignKeyConstraintSuitethat exerciseREPLACE TABLEwith constraints through the atomic catalog path (StagingInMemoryTableCatalog). Verified that all 4 new tests fail without the fix and pass with it. All existing tests in these suites continue to pass.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.6 <noreplyanthropic.com>
Closes #54322 from yyanyy/staging_catalog_constraint.
Authored-by: Yan Yan yyanyyyy@gmail.com