Address PKIXNameConstraintValidator Bug#2260
Open
xSammyKang wants to merge 1 commit intobcgit:mainfrom
Open
Conversation
Addresses a bug in the intersectDNS function of PKIXNameConstraintValidator that treats DNS names with the same value as not within their domain. This leads to an issue where if there exist a certificate root and subordinate with the same name constraint, neither will be recognized.
Author
|
Currently, during the intersectDNS() call, withinDomain() is used to check whether incoming DNS name constraints are within the domain of existing naming constraints or vice versa. However, because the length of the arrays produced when split() is called will be the same for DNS names that are the same, both calls will return false. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a bug in the intersectDNS function of PKIXNameConstraintValidator that treats DNS names with the same value as not within their domain. This leads to an issue where if there exist a certificate root and subordinate with the same name constraint, neither will be recognized.