Run tests on PHP 8.5 and update test environment#36
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the test environment to run tests on PHP 8.4 and 8.5, and updates dependencies and GitHub Actions workflow to their latest versions. This builds on previous work to modernize the test infrastructure for this ReactPHP CSV library.
Changes:
- Updated runtime dependencies (react/stream from ^1.2 to ^1.4)
- Updated dev dependencies (react/child-process from ^0.6.3 to ^0.6.7, react/event-loop from ^1.2 to ^1.6)
- Added PHP 8.4 and 8.5 to the CI test matrix and upgraded CI infrastructure (Ubuntu 24.04, actions/checkout@v6)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Updated react/stream, react/child-process, and react/event-loop dependencies to newer versions |
| .github/workflows/ci.yml | Added PHP 8.4 and 8.5 to test matrix, upgraded Ubuntu runner to 24.04, and updated actions/checkout to v6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #33, #35, reactphp/stream#179, reactphp/event-loop#282, reactphp/child-process#119, and clue/framework-x#297