Closed
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
renaudhartert-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
exhaustructlinter from the CI lint workflow.Why
The
exhaustructlinter requires every field in a struct literal to be explicitly initialized, even when the zero value is intentional. This goes against idiomatic Go, where leveraging zero values is a core language feature and a deliberate design choice.The linter was scoped to
bundle/direct/dresourcesto catch missing fields when constructing API resource structs. In practice, the Go compiler and tests already catch meaningful omissions, and the linter creates friction without proportional benefit — it forces boilerplate likeField: ""orField: nilthat adds noise without adding safety.What changed
Interface changes
None.
Behavioral changes
None. The linter only ran in CI; removing it has no effect on the CLI's behavior.
Internal changes
exhaustructfrom theenablelist in.golangci.yaml.exclusionssection.How is this tested?
make lintfullpasses with 0 issues.