Skip to content

add comment to fix: allow json fields to accept objects in edit mode … #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kulikp1 wants to merge 1 commit into
base: next
Choose a base branch
from
Open

add comment to fix: allow json fields to accept objects in edit mode … #483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions adminforth/spa/src/components/ResourceForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ const columnError = (column: AdminForthResourceColumnCommon) => {
if (column.type === 'json' && !column.isArray?.enabled && currentValues.value[column.name]) {
const value = currentValues.value[column.name];
try {
// add object check to allow json fields to be objects in edit mode without throwing validation error, but still validate if the string is a valid json or not
if (typeof value === 'object') {
JSON.parse(JSON.stringify(value));
}
Expand Down Expand Up @@ -289,6 +290,8 @@ onMounted(() => {
}
}
} else if (currentValues.value[column.name]) {
// Todo: reconsider basic issue
// if value is not string, we should stringify it, but object we already stringify in setCurrentValue, so we should not stringify it again to prevent double stringification
if (typeof currentValues.value[column.name] !== 'string') {
currentValues.value[column.name] = JSON.stringify(currentValues.value[column.name], null, 2)
}
Expand Down