implement manual approval for Docker CE release workflow#705
implement manual approval for Docker CE release workflow#705ilopezluna wants to merge 2 commits intomainfrom
Conversation
…w and enhance job structure
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
release-cli-docker-ce-waitjob no longer has the 360-minute timeout that existed on the originalrelease-cli-docker-cejob; consider adding an explicit timeout to the wait job so that it can’t block indefinitely if the release-repo workflow stalls. - You removed
timeout-minutesfromrelease-cli-desktop,bump-pinata, andverify-docker-ce; if that wasn’t intentional, it may be worth restoring timeouts to avoid long-running or stuck jobs in these parts of the workflow.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `release-cli-docker-ce-wait` job no longer has the 360-minute timeout that existed on the original `release-cli-docker-ce` job; consider adding an explicit timeout to the wait job so that it can’t block indefinitely if the release-repo workflow stalls.
- You removed `timeout-minutes` from `release-cli-desktop`, `bump-pinata`, and `verify-docker-ce`; if that wasn’t intentional, it may be worth restoring timeouts to avoid long-running or stuck jobs in these parts of the workflow.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
.github/workflows/release.yml
Outdated
| -f release_live=true | ||
| echo "✅ Plugin release workflow triggered in docker/release-repo" | ||
|
|
||
| - name: Post trigger summary |
There was a problem hiding this comment.
gh workflow run has just been updated to return the workflow ID!
cli/cli#4001 (comment)
❤️ https://github.blog/changelog/2026-02-19-workflow-dispatch-api-now-returns-run-ids/
There was a problem hiding this comment.
Hi from gh! 👋 Sorry to interrupt. I just noticed this PR via links and thought sharing these:
-
When run
gh workflow runnon-interactively (as in here, in Actions), the dispatched run URL is the only thing that is printed on stdout. So you can safely drop stderr redirection (2>&1) to avoid any accidental matches against error messages if they happen to include URLs of the same pattern. -
Usually it takes a few weeks for new
ghversions to be fully propagated across Actions runner images. For example, you can watch for changes onubuntu-latestimage here.
Cheers
…it steps and enhancing trigger feedback
7e77d7c to
523b489
Compare
Problem
The release workflow was blocking while waiting for the
docker/release-repoworkflow to complete. The external workflow requires manual approval at thedeploy-to-livegate, which could take hours to be approved. During this wait time, the entirerelease-cli-docker-cejob would be stuck, consuming GitHub Actions minutes and blocking other dependent jobs.Solution
Split the
release-cli-docker-cejob into two separate jobs with a manual approval gate:release-cli-docker-ce-trigger- Triggers the packaging and release-repo workflows, then completes immediatelyrelease-cli-docker-ce-wait- Requires manual approval via GitHub environment protection before waiting for the release-repo workflow to completeI also removed the timeouts, I think they are unnecessary, I will get back any of them if turns out they are needed