fix: limit items on response from ERS#3699
Open
PashaFG wants to merge 9 commits intoelectron:mainfrom
Open
Conversation
Author
|
Good day. Within the framework of this PR, a more optimal solution to the problem of searching for the required version was found. In the current solution, we no longer need to use a hack with the API intended for the UI part of the application and can return to a method specifically designed for this I will be glad to receive your review of this solution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Issue: #3698
But to the number of elements available for return in the authFetch('versions/sorted') endpoint, if we add an update to an older version. Since in the first N (default: 50), sorted by version name, we do not get the newly created one.
This number is regulated on the electron-release-server side. https://github.com/ArekSredzki/electron-release-server/blob/master/config/views.js#L46
To solve the problem I added a loop refetch versions list, if in response we receive a number of elements less than indicated in request.key
total.I also update
interface ERSVersionSorted, becausepagein response has typestring | number, page in ERS takes from query params, but default value is number "0"