fix:Can't put a space in app name #4055#4058
Open
dvansari65 wants to merge 1 commit intoelectron:mainfrom
Open
fix:Can't put a space in app name #4055#4058dvansari65 wants to merge 1 commit intoelectron:mainfrom
dvansari65 wants to merge 1 commit intoelectron:mainfrom
Conversation
Member
MarshallOfSound
left a comment
There was a problem hiding this comment.
Did you dive into where this is happening inside electron-installer-dmg? I traced the code just now and it looks like everything is using args not string concatenation so spaces shouldn't matter.
We also build an app internally called Foo Bar.app which correctly builds as Foo Bar.dmg without error. Can you provide a repro for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
I wrapped app name and app path in double quote, this avoids macOS treating spaces as argument separators during