Update threejs-fundamentals.md#122
Conversation
I made some changes to a paragraph. I fixed the grammar. Also, I improved the readability of the text.
Lecrapouille
left a comment
Lecrapouille
left a comment
There was a problem hiding this comment.
Sorry my English is poor, I'm not sure to understand sentences. My suggestions are quoted.
| Note there are some esoteric details here. For three.js to work, it must | ||
| have a canvas. You have a choice of either passing a canvas into three.js | ||
| or not. If you decide not to pass a canvas into three.js, a canvas will be | ||
| created for you. The canvas that was created will still have to be added to |
There was a problem hiding this comment.
Should not be: ... a canvas will be created for you. Anyway, in both cases the canvas that was created will still have to be added to ...
| your document. I think passing a canvas to three.js feels more flexible | ||
| because the canvas can be put anywhere, and the code will still find it. | ||
| Otherwise, not passing in a canvas into three.js might cause two problems. | ||
| First, your use case might change. Lastly, changes will have to be made |
There was a problem hiding this comment.
Should not the . be a : instead ? So: two problems: - firstly, your use case might change; - secondly, changes ...
There was a problem hiding this comment.
... your use case might change ... => your use case might change: modify its localization
| or not. If you decide not to pass a canvas into three.js, a canvas will be | ||
| created for you. The canvas that was created will still have to be added to | ||
| your document. I think passing a canvas to three.js feels more flexible | ||
| because the canvas can be put anywhere, and the code will still find it. |
There was a problem hiding this comment.
... can be put anywhere ... => can be place anywhere inside the document ?
There was a problem hiding this comment.
... and the code will still find it ... => and the code will still know where to locate it
| because the canvas can be put anywhere, and the code will still find it. | ||
| Otherwise, not passing in a canvas into three.js might cause two problems. | ||
| First, your use case might change. Lastly, changes will have to be made | ||
| to the code. |
There was a problem hiding this comment.
... to the code. => ... in the code source.
4 participants
I made some changes to a paragraph. I fixed the grammar. Also, I improved the readability of the text.