Add sshConfigs.xml to JetBrains gitignore#4799
Open
digicommons wants to merge 1 commit intogithub:mainfrom
Open
Add sshConfigs.xml to JetBrains gitignore#4799digicommons wants to merge 1 commit intogithub:mainfrom
digicommons wants to merge 1 commit intogithub:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
JetBrains includes sensitive data, such as host name, key path and username in
sshConfigs.xml. While this data doesn't contain the credentials themselves, the included metadata is sensitive enough to be excluded (f.e. in order to prevent social engineering).Links to documentation supporting these rule changes
JetBrains actively promotes committing this file to project repositories. On the other hand users have been pointing out that the caveats of committing this file are not explained good enough.
Merge and Approval Steps