KEP-8902: Flavor-Aware Dominant Resource Share (DRS)

[mukund-wayve]

What type of PR is this?

/kind feature

/kind api-change

What this PR does / why we need it:

Creates a KEP for #8902

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This is my first time writing a KEP. I've tried to follow the template and read a few different KEPs to be consistent.

Does this PR introduce a user-facing change?

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: mukund-wayve / name: Mukund Muralikrishnan (1ac41fd, 6e3c0d3, 814ba6b, 9ca94a8, c06d204, c86302d, c9e82d2)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mukund-wayve
Once this PR has been reviewed and has the lgtm label, please assign gabesaba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @mukund-wayve!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mukund-wayve. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	1ac41fd
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6992f29f83b53200083a56ba

[mimowo]

/ok-to-test

[kshalot]

I assume the implementation will be a follow-up, so the release note for this PR should be dropped.

[mimowo]

/release-note-edit

NONE

[mukund-wayve]

Hi @mimowo, Could you please advise on who would be the best person to review this KEP? We believe this feature would be valuable and would love to see it considered for the upcoming release. Any guidance would be greatly appreciated

[mimowo]

Since this API is only meant for FairSharing computations I think it will be better to put it under fairSharing field, the question remains which level, let me consider the options:

1. ConfigMap, this is very analogous case to AdmissionFairSharing weights here, so this could be the analogous field under the FairSharing construct
2. ClusterQueue, under the pre-exsting "fairSharing" field
3. ResourceFlavor (as proposed here), but under the extra "fairSharing" field

I guess the main question is if you have use cases for different multipliers the ResourceFlavor, otherwise I would be leaning to (1.) for simplicity to get going in Alpha.

[mimowo]

I see you discuss some of that under the Alternatives section, but discussing the configMap option (1.) seems missing there.

[mimowo]

Hi @mukund-wayve this looks like a very useful feature, and I can totally support it, let me address the questions.

Hi @mimowo, Could you please advise on who would be the best person to review this KEP?

I think @gabesaba will be best here, but probably me and @tenzen-y will also keep an eye on it. I believe @amy , @kannon92, @sohankunkerkar may also be interested.

We believe this feature would be valuable and would love to see it considered for the upcoming release.

The upcoming release, 0.17, is already very packed, so cannot promise. FYI, 0.18 is planned mid May (we release every 2 months).

Any guidance would be greatly appreciated

1. Seeing your KEP I think it should be relatively easy implementation-wise, and I agree it is useful - I think you can start prototyping already. Seeing a working prototype will certainly give reviewers a useful signal that the idea works, and it is worth investing review time here.

2. Try to engage as many other reviewers as possible. Every additional pair of eyes which gave a review pass builds confidence from the reviewer's PoV.

3. Presenting this idea at the wg-batch community meeting (next Feb 26th) where we discuss the designs would be very useful to discuss the question like in the comment