Skip to content

Comments

Apply admission checks covering all CQ resources to workloads before flavor assigned#9359

Open
Singularity23x0 wants to merge 10 commits intokubernetes-sigs:mainfrom
Singularity23x0:7254-mk-admcheck-bugfix
Open

Apply admission checks covering all CQ resources to workloads before flavor assigned#9359
Singularity23x0 wants to merge 10 commits intokubernetes-sigs:mainfrom
Singularity23x0:7254-mk-admcheck-bugfix

Conversation

@Singularity23x0
Copy link
Contributor

@Singularity23x0 Singularity23x0 commented Feb 19, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

Bug:
Currently, the MultiKueue admission check, which is required to span all resources of a Cluster Queue, is applied to a workloads only if it has an admission or all checks on the CQ span all flavors.
This led to an issue described in #7254.

Fix:
The PR updates the logic assigning/removing admission checks to/from the workload in Workload Controller.
Now, all checks that apply to all resource flavors of a Cluster Queue will be applied to the Workload even before an admission with a flavor is populated.
For the MK AC - this means the check should be applied to all workloads targeting the CQ anointed with one.

Which issue(s) this PR fixes:

Fixes #7254

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

Workloads will be assigned ACs which cover all CQ resource flavors sooner (before an admission is recorded), resulting in their earlier presence in the Status field of affected Workloads. This was already possible under specific circumstances, which this PR loosens by expanding the amount of cases such checks can be added in advance.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Feb 19, 2026
@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit bc20b11
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69984947e19826000876936e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Singularity23x0
Once this PR has been reviewed and has the lgtm label, please assign gabesaba, mbobrovskyi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 19, 2026
@Singularity23x0 Singularity23x0 marked this pull request as ready for review February 20, 2026 11:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combination of MultiKueue and a non-MultiKueue AdmissionChecks may return an empty list

2 participants