Apply admission checks covering all CQ resources to workloads before flavor assigned#9359
Open
Singularity23x0 wants to merge 10 commits intokubernetes-sigs:mainfrom
Open
Apply admission checks covering all CQ resources to workloads before flavor assigned#9359Singularity23x0 wants to merge 10 commits intokubernetes-sigs:mainfrom
Singularity23x0 wants to merge 10 commits intokubernetes-sigs:mainfrom
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Singularity23x0 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Bug:
Currently, the MultiKueue admission check, which is required to span all resources of a Cluster Queue, is applied to a workloads only if it has an admission or all checks on the CQ span all flavors.
This led to an issue described in #7254.
Fix:
The PR updates the logic assigning/removing admission checks to/from the workload in Workload Controller.
Now, all checks that apply to all resource flavors of a Cluster Queue will be applied to the Workload even before an admission with a flavor is populated.
For the MK AC - this means the check should be applied to all workloads targeting the CQ anointed with one.
Which issue(s) this PR fixes:
Fixes #7254
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?