Speedup make test-integration by avoiding generate-code#9363
Speedup make test-integration by avoiding generate-code#9363gabesaba wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
…ests Move the ordering constraint into verify-helm-prereqs instead, so that make verify -j remains race-free without penalising make test-integration.
k8s-ci-robot
added
release-note-none
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabesaba The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
|
||
| .PHONY: manifests | ||
| manifests: controller-gen generate-code ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | ||
| manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. |
There was a problem hiding this comment.
As far I remember generate-code is required for manifest.
/cc @vladikkuzn
| ##@ Development | ||
|
|
||
| .PHONY: manifests | ||
| manifests: controller-gen generate-code ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. |
There was a problem hiding this comment.
This feels risky, and it is not self-explanatory impact to perf of running integration tests.
Instead of optimizing manifests could we rather have a dedicated goal run-test-integration which would skip manifests and code-generation, basically assuming a developer did all of that before, wdyt?
| .PHONY: verify-helm-prereqs | ||
| verify-helm-prereqs: ## Prerequisites for Helm checks. | ||
| verify-helm-prereqs: compile-crd-manifests update-helm generate-helm-docs prepare-release-branch | ||
| verify-helm-prereqs: verify-go-prereqs compile-crd-manifests update-helm generate-helm-docs prepare-release-branch |
There was a problem hiding this comment.
how is that related. or a drive-by cleanup?
4 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Reverts the unintended side effect of #8988, which fixed a race condition in make verify -j (#8906) but inadvertently slowed down integration tests. This refines the fix by scoping the ordering constraint to the verify flow only.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?