feat: add local queue metrics config#9371
feat: add local queue metrics config#9371mykysha wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mykysha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XL
| // LocalQueueMetrics defines the configuration options for local queue metrics. | ||
| // If left empty, then metrics will expose for all local queues across namespaces. | ||
| type LocalQueueMetrics struct { | ||
| // Enable is a knob to allow metrics to be exposed for local queues. Defaults to false. |
There was a problem hiding this comment.
I think we are trying to phase out Enable for configs. Setting this field should make it obvious that we want this.
There was a problem hiding this comment.
Makes sense, will adjust accordingly
| github.com/Masterminds/vcs v1.13.3/go.mod h1:TiE7xuEjl1N4j016moRd6vezp6e6Lz23gypeXfzXeW8= | ||
| github.com/MirrexOne/unqueryvet v1.5.3 h1:LpT3rsH+IY3cQddWF9bg4C7jsbASdGnrOSofY8IPEiw= | ||
| github.com/MirrexOne/unqueryvet v1.5.3/go.mod h1:fs9Zq6eh1LRIhsDIsxf9PONVUjYdFHdtkHIgZdJnyPU= | ||
| github.com/NYTimes/gziphandler v1.1.1/go.mod h1:n/CVRwUEOgIxrgPvAQhUUr9oeUtvrhMomdKFjzJNB0c= |
There was a problem hiding this comment.
This also appeared in one of my PRs and I couldn't really explain how it got there. Any idea why this was modified?
There was a problem hiding this comment.
I think it appeared here after running make generate, will look deeper to find what exactly caused it
|
/assign I'd like to do the first round of reviews for this. |
|
Please fix the merge conflicts when you get a chance also. |
|
And sorry I realize this is draft. let me know when its ready for review. |
3 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add configuration for the localqueue metrics visibility
Which issue(s) this PR fixes:
Part of #8830
Special notes for your reviewer:
Does this PR introduce a user-facing change?