Skip to content

Comments

Fix library routerview race condition#5412

Open
creeperkatze wants to merge 1 commit intomodrinth:mainfrom
creeperkatze:fix-library-router-view-race-condition
Open

Fix library routerview race condition#5412
creeperkatze wants to merge 1 commit intomodrinth:mainfrom
creeperkatze:fix-library-router-view-race-condition

Conversation

@creeperkatze
Copy link
Contributor

When navigating to an instance page locally, vue's suspense kept the library page mounted while the instance page loads asynchronously. During this transition, the RouterView reacts to the route change and renders the instance's mods component with the wrong props, messing up vue's state.

This didn't reproduce in production builds because the tauri backend responds fast enough that the suspense transition was effectively instant.

Fix: Added a route guard on the RouterView so it only renders when on a /library route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant