Fix library routerview race condition#5412
Open
creeperkatze wants to merge 1 commit intomodrinth:mainfrom
Open
Fix library routerview race condition#5412creeperkatze wants to merge 1 commit intomodrinth:mainfrom
creeperkatze wants to merge 1 commit intomodrinth:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When navigating to an instance page locally, vue's suspense kept the library page mounted while the instance page loads asynchronously. During this transition, the RouterView reacts to the route change and renders the instance's mods component with the wrong props, messing up vue's state.
This didn't reproduce in production builds because the tauri backend responds fast enough that the suspense transition was effectively instant.
Fix: Added a route guard on the RouterView so it only renders when on a /library route.