Add Stringable interface support in Validator.php#349
Open
spaze wants to merge 1 commit intonette:v3.2from
Open
Add Stringable interface support in Validator.php#349spaze wants to merge 1 commit intonette:v3.2from
spaze wants to merge 1 commit intonette:v3.2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
addRulemethods supportStringablefor$errorMessage:but when I pass an object of
class MyRule implements Stringable, I'll get aTypeError:That's because
Nette\Forms\Validatoronly supportsNette\HtmlStringable:https://github.com/nette/forms/blob/ae11e90098c39576d8744d6bacc35dd858ed4167/src/Forms/Validator.php#L57C33-L58
so an
Stringableobject will reachpreg_replace_callback()and it doesn't know what to do with it.There are several options here. The first is to return the
Stringableobject type-casted to string, which is what I've implemented in this PR, another would be to type-cast$messagehere:forms/src/Forms/Validator.php
Line 106 in ae11e90
Let me know if I should change the PR to do that.