Conversation
|
Review requested:
|
77ede22 to
3423c21
Compare
3423c21 to
451f8a7
Compare
cf2609b to
a3ce99d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57343 +/- ##
==========================================
+ Coverage 89.72% 89.76% +0.04%
==========================================
Files 675 674 -1
Lines 204797 204883 +86
Branches 39344 39385 +41
==========================================
+ Hits 183752 183915 +163
+ Misses 13324 13264 -60
+ Partials 7721 7704 -17 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ovflowd
left a comment
There was a problem hiding this comment.
This is the result of many months of arduous work between many awesome folks, including @flakey5 @AugustinMauroy @araujogui @ovflowd @avivkeller and others.
I'm so proud of what we are achieving here and this is a huge step towards a modern tooling and a revamped API docs within Node.js
Approving, as I believe this is ready!
This comment was marked as resolved.
This comment was marked as resolved.
f60729c to
efb7c12
Compare
|
Looks like swc (our minifier), does not support all builds, causing most of the CI failures. |
What minifier? The HTML one? |
|
Yes. SWC's HTML minifier doesn't have bindings for some of the more niche machines. It has the following bindings: |
Switches over to using the new doc generation tooling. For more background on this, please see nodejs#52343 Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> Co-authored-by: Claudio W <cwunder@gnome.org> Co-authored-by: avivkeller <me@aviv.sh> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
fa670b4 to
95a3dc8
Compare
|
@Renegade334 I removed a test you added 17h ago as this test becomes irrelevant with doc-kit (it tests for that already and that's also covered (or planned to be covered, if not yet) on the new linting package for @node-core's lint pkg) |
|
de nada 🫡 |
That doesn't sound like a good reason to remove it, if it already passes why not keep it? If it doesn't, we should investigate why. |
It would have passed, the issue is that it relies on the old tooling internals, you can compare the imports. Also seems like René is fine with the removal. |
|
This PR is ready to land once the CI is back up (and this passes) |

Switches over to using the new doc generation tooling. For more background on this, please see #52343
Currently a draft just to get feedback on the approach to this integration.cc @nodejs/web-infra
Notable Change info (by @avivkeller):
The Node.js Website and Website Infrastructure teams have introduced a brand-new documentation pipeline, modernizing how our API docs are generated. While the documentation site may look familiar today, we are hard at work making a completely refreshed user interface in the very near future!