Add TLS guides for AWS EKS with Ingress and Gateway API#415
Open
welteki wants to merge 4 commits intoopenfaas:masterfrom
Open
Add TLS guides for AWS EKS with Ingress and Gateway API#415welteki wants to merge 4 commits intoopenfaas:masterfrom
welteki wants to merge 4 commits intoopenfaas:masterfrom
Conversation
Update documentation across multiple pages to recommend Traefik as the default ingress controller instead of ingress-nginx: - Switch ingress controller references from nginx to Traefik - Update installation commands to use arkade install traefik2 - Replace nginx-specific annotations with Traefik equivalents - Update ingressClassName from nginx to traefik - Add Traefik timeout configuration guide Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
- Document how to use AWS Load Balancer Controller with Traefik on EKS - Add required annotation for internet-facing NLB provisioning - Fix typo in main TLS guide Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
This comment has been minimized.
This comment has been minimized.
c824b40 to
6d2f377
Compare
This comment has been minimized.
This comment has been minimized.
6d2f377 to
52423cc
Compare
This comment has been minimized.
This comment has been minimized.
52423cc to
a321d9b
Compare
This comment has been minimized.
This comment has been minimized.
a321d9b to
804f36c
Compare
This comment has been minimized.
This comment has been minimized.
804f36c to
b36d169
Compare
This comment has been minimized.
This comment has been minimized.
Reorganise the TLS reference page to cover both Ingress and Gateway API approaches. Add sections for Envoy Gateway with cert-manager and AWS EKS with the AWS Load Balancer Controller. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
b36d169 to
5880f91
Compare
This comment has been minimized.
This comment has been minimized.
Replace the FunctionIngress/ingress-operator approach with Kubernetes Gateway API. The updated guide covers adding Gateway listeners per function domain, creating HTTPRoutes that rewrite paths to /function/NAME/, and cert-manager integration for TLS. Includes implementation-specific tabs for Envoy Gateway (regex rewrite workaround) and standard Gateway API (ReplacePrefixMatch). Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewSummary
Approval rating (1-10)9 The PR significantly improves the documentation by providing modern, production-ready TLS configurations and removing deprecated components. The technical accuracy is high, and the guides are comprehensive. Summary per fileSummary per file
Overall AssessmentThis PR modernizes OpenFaaS TLS documentation by transitioning from legacy Ingress-based approaches to the more robust Gateway API standard, while providing comprehensive cloud-native guidance for AWS EKS deployments. The changes remove deprecated components (ingress-nginx) and introduce best practices for production TLS configurations. Detailed ReviewDetailed ReviewTechnical Accuracy
Security Considerations
Completeness
Consistency
Potential Improvements
Minor Issues
Positive Aspects
AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add comprehensive TLS documentation for AWS EKS deployments covering both traditional Ingress and modern Gateway API approaches.
Motivation and Context
How Has This Been Tested?
Documentation updates - verified rendering and link structure.
Types of changes
Checklist:
git commit -s