Skip to content

Comments

Add support for sconstruct and sconscript extensions#563

Open
seanbudd wants to merge 3 commits intopre-commit:mainfrom
seanbudd:patch-2
Open

Add support for sconstruct and sconscript extensions#563
seanbudd wants to merge 3 commits intopre-commit:mainfrom
seanbudd:patch-2

Conversation

@seanbudd
Copy link
Contributor

@seanbudd seanbudd commented Feb 4, 2026

Scons scripting support: https://scons-cookbook.readthedocs.io/en/latest/#sharing-variables-between-sconscript-files

These are files named sconstruct or sconscript.
It might be worth including them with python, but that might cause some tools to break by default, as it's not normal python code.

Comment on lines 414 to 415
'sconstruct': {'text', 'scons'},
'sconscript': {'text', 'scons'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't scons have a funny capitalization convention for these files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - the file names can be mixed caps. I guess these dictionaries aren't case insensitive then?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leading SC are conventionally capitalized, so it'd be best to integrate them as such. I'd also recommend adding SCsub, as that's an alias for SConscript used by Godot repositories

Suggested change
'sconstruct': {'text', 'scons'},
'sconscript': {'text', 'scons'},
'SConstruct': {'text', 'scons'},
'SConscript': {'text', 'scons'},
'SCsub': {'text', 'scons'},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Is the capitalisation just to match the defacto standard or is this handled in a case sensitive manner as well? Will I need to rename our files to capitalise them correctly for them to be caught by precommit

Co-authored-by: Thaddeus Crews <repiteo@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants