gh-141510: Check argument in PyDict_Contains()#145083
Merged
vstinner merged 2 commits intopython:mainfrom Feb 21, 2026
Merged
Conversation
PyDict_Contains() and PyDict_ContainsString() now fail with SystemError if the first argument is not a dict, frozendict, dict subclass or frozendict subclass.
Comment on lines
+5004
to
+5007
| if (!PyAnyDict_Check(op)) { | ||
| PyErr_BadInternalCall(); | ||
| return -1; | ||
| } |
Member
There was a problem hiding this comment.
Would you mind adding a versionchanged for this in the docs? This looks good otherwise.
Member
Author
There was a problem hiding this comment.
We do not document SystemError errors in the documentation. It's not really part of the API, but provided to be kind with developers.
Member
There was a problem hiding this comment.
I'm not sure that's necessarily a good thing. It's helpful for extension authors to know whether they need to validate their input.
Member
Author
There was a problem hiding this comment.
They always need to validate their input. You're not supposed to hit SystemError in regular code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyDict_Contains() and PyDict_ContainsString() now fail with SystemError if the first argument is not a dict, frozendict, dict subclass or frozendict subclass.