Prohibit access via class for instance-only attributes#20855
Open
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Open
Prohibit access via class for instance-only attributes#20855ilevkivskyi wants to merge 1 commit intopython:masterfrom
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: setuptools (https://github.com/pypa/setuptools)
+ setuptools/config/_apply_pyprojecttoml.py:328: error: Cannot access instance-only attribute "global_options" on class object [misc]
|
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240 (yes, you read that right, three digits)
I am taking a conservative approach and flag only cases that would definitely fail at runtime. Note we already have a more strict check for this for generics, but it is tricky to avoid double errors, so I think it is fine to have two errors sometimes.
I also update an outdated comment that confused me for a while.