[pyasn1] Fix componentType to accept Asn1Type in SequenceOf#15442
Open
emmanuel-ferdman wants to merge 1 commit intopython:mainfrom
Open
[pyasn1] Fix componentType to accept Asn1Type in SequenceOf#15442emmanuel-ferdman wants to merge 1 commit intopython:mainfrom
emmanuel-ferdman wants to merge 1 commit intopython:mainfrom
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The
componentTypeattribute inSequenceOfAndSetOfBasewas typed asNamedTypes | None, but ASN.1 SEQUENCE OF / SET OF constructs take a singleAsn1Type(likeInteger()), notNamedTypes. This caused false positives when subclassingSequenceOfwith a component type, which is the standard usage shown in pyasn1's own documentation. The fix also removes the# type: ignore[assignment]that were added to ldap3 stubs.Fixes #15369