Upgrade to Rails 8 defaults and clean up#6277
Open
larouxn wants to merge 1 commit intorubygems:masterfrom
Open
Upgrade to Rails 8 defaults and clean up#6277larouxn wants to merge 1 commit intorubygems:masterfrom
larouxn wants to merge 1 commit intorubygems:masterfrom
Conversation
95c00a6 to
c5af18b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6277 +/- ##
==========================================
- Coverage 38.65% 38.02% -0.63%
==========================================
Files 487 487
Lines 10728 10787 +59
==========================================
- Hits 4147 4102 -45
- Misses 6581 6685 +104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c5af18b to
9a9e568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposing we upgrade from Rails 7.2 to Rails 8 defaults. We're already using two of the three new Rails 8.0 defaults. The only one we're not currently using is
action_dispatch.strict_freshness = truebut that's really just RFC 7232 spec compliance and as such unlikely to cause any issues. All in all this is more of no-op cleanup than any serious upgrade.rubygems.org/config/application.rb
Lines 32 to 40 in 6b85477
rubygems.org/config/initializers/new_framework_defaults_8_0.rb
Line 22 in 6b85477
Inspired by #6275
How?
7.2to8.0active_support.to_time_preserves_timezoneconfig as such is now defaultnew_framework_defaults_8_0.rbincluding itsRegexp.timeoutconfig as such is now default