Skip to content

Comments

fix(hex): scope param renames to their respective operations#3295

Merged
waleedlatif1 merged 1 commit intostagingfrom
fix/tools
Feb 22, 2026
Merged

fix(hex): scope param renames to their respective operations#3295
waleedlatif1 merged 1 commit intostagingfrom
fix/tools

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • Scoped param field renames in the Hex block's tools.config.params to their respective operations
  • Prevents stale values from hidden conditional subblocks leaking across operations (e.g., runStatusFilter from get_project_runs overriding statusFilter on list_projects)

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Feb 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Feb 22, 2026 1:48am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 22, 2026

Greptile Summary

Scoped parameter field renames in the Hex block's tools.config.params to their respective operations, preventing stale values from hidden conditional subblocks from leaking across operations.

Key Changes:

  • Added operation check (op) variable to conditionally scope parameter mappings
  • Fixed bug where runStatusFilter from get_project_runs could override statusFilter on other operations
  • Properly scoped offset, projectStatus, runStatusFilter, groupIdInput, groupId, collectionName, and collectionDescription to their respective operations

Issues Found:

  • Missing parameter mappings for list_projects operation (statusFilter and includeArchived fields are defined in subBlocks but not mapped in the params function)

Confidence Score: 3/5

  • Safe to merge with missing functionality for list_projects filters
  • The PR correctly fixes the parameter leakage bug by scoping renames to operations, but is incomplete - it doesn't map statusFilter and includeArchived for list_projects, meaning those UI fields won't work
  • apps/sim/blocks/blocks/hex.ts needs the missing parameter mappings added

Important Files Changed

Filename Overview
apps/sim/blocks/blocks/hex.ts Scoped parameter renames to specific operations to prevent cross-contamination; missing statusFilter and includeArchived mappings for list_projects

Last reviewed commit: 893db4f

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit 04286fc into staging Feb 22, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/tools branch February 22, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant