BridgeJS: Fix static method and constructor codegen dropping default parameter values#669
Merged
kateinoigakukun merged 1 commit intoswiftwasm:mainfrom Feb 21, 2026
Conversation
4ae9e79 to
c702ac2
Compare
kateinoigakukun
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Three codegen paths in
BridgeJSLink.swiftconstructed JS parameter lists by joining parameter names directly, ignoring default values. This caused a mismatch where.d.tsdeclarations correctly marked defaulted parameters as optional (?), but the generated.jsomitted the defaults - so calling e.g.MathOperations.subtract(10)from TypeScript would compile but passundefinedat runtime instead of the Swift default.1.
renderEnumStaticFunctionand 2.renderStaticMethodForExportObjectboth usedparameters.map { $0.name }.joined(separator: ", ")instead ofDefaultValueUtils.formatParameterList(parameters). The fix applies the same pattern already used by constructor codegen and import-side method codegen.3. Global namespace constructor
.d.tsrendering manually formatted constructor parameters without checkingparam.hasDefault, so the?marker was missing. Added the optional suffix check inline.Before:
After:
Added an E2E test that calls
MathOperations.subtract(10.0)(omitting the defaultedbparameter) and asserts it returns5.0.