FGA_2: listResources(), get/update/delete resource_by_external_id

[swaroopAkkineniWorkos]

Description

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

[swaroopAkkineniWorkos]

@greptile review

[greptile-apps]

Greptile Summary

This PR adds Fine-Grained Authorization (FGA) resource management capabilities by external ID to the Python SDK. The implementation adds four new methods to the Authorization module: get_resource_by_external_id(), update_resource_by_external_id(), delete_resource_by_external_id(), and list_resources().

• Implements both synchronous and asynchronous variants following the SDK's established dual-client pattern
• Adds proper type definitions with ResourceListFilters and ResourcesListResource for pagination support
• Provides comprehensive test coverage using the @pytest.mark.sync_and_async pattern
• Tests cover URL construction, parameter handling, pagination, cascade delete functionality, and auto-pagination
• All implementations follow existing code patterns in the repository (URL path construction, parameter handling, HTTP methods)
• No security issues identified - no sensitive data logging, proper use of PATCH/DELETE methods, consistent with existing patterns

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The implementation strictly follows established SDK patterns for dual sync/async support, uses proper HTTP methods and type definitions, has comprehensive test coverage including edge cases and auto-pagination, and introduces no security concerns or custom instruction violations
• No files require special attention

Important Files Changed

Filename	Overview
src/workos/authorization.py	Adds four new resource management methods (get, update, delete, list) by external_id, following established SDK patterns with proper sync/async implementations
tests/test_authorization_resource_external_id.py	Comprehensive test coverage for all new resource methods with both sync/async variants, edge cases, and auto-pagination testing

Sequence Diagram

sequenceDiagram
    participant Client
    participant Authorization
    participant HTTPClient
    participant API

    Note over Client,API: Resource Operations by External ID

    Client->>Authorization: get_resource_by_external_id(org_id, type, ext_id)
    Authorization->>HTTPClient: GET /authorization/organizations/{org_id}/resources/{type}/{ext_id}
    HTTPClient->>API: HTTP Request
    API-->>HTTPClient: Resource JSON
    HTTPClient-->>Authorization: Response
    Authorization-->>Client: Resource object

    Client->>Authorization: update_resource_by_external_id(org_id, type, ext_id, name, desc)
    Authorization->>HTTPClient: PATCH /authorization/organizations/{org_id}/resources/{type}/{ext_id}
    HTTPClient->>API: HTTP Request with JSON body
    API-->>HTTPClient: Updated Resource JSON
    HTTPClient-->>Authorization: Response
    Authorization-->>Client: Resource object

    Client->>Authorization: delete_resource_by_external_id(org_id, type, ext_id, cascade_delete)
    Authorization->>HTTPClient: DELETE /authorization/organizations/{org_id}/resources/{type}/{ext_id}
    HTTPClient->>API: HTTP Request with params
    API-->>HTTPClient: 202 Accepted
    HTTPClient-->>Authorization: Response
    Authorization-->>Client: None

    Client->>Authorization: list_resources(org_id, filters, pagination)
    Authorization->>HTTPClient: GET /authorization/organizations/{org_id}/resources
    HTTPClient->>API: HTTP Request with query params
    API-->>HTTPClient: Paginated List JSON
    HTTPClient-->>Authorization: Response
    Authorization-->>Client: WorkOSListResource

Loading

_{Last reviewed commit: 63f2f60}

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}