fix console.log(error) should include stack trace#40
Open
ammarahm-ed wants to merge 2 commits intomainfrom
Open
fix console.log(error) should include stack trace#40ammarahm-ed wants to merge 2 commits intomainfrom
ammarahm-ed wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes issue #38 by modifying the console logging behavior to include stack traces when logging Error objects, matching Node.js behavior.
Changes:
- Modified the
transformJSObjectfunction in Console.cpp to detect Error objects and append their stack traces - Added logic to check if an object is an error using
napi_is_errorand retrieve its stack property
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38