Skip to content

fix console.log(error) should include stack trace #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ammarahm-ed wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix console.log(error) should include stack trace #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d90563
fix console.log(error) should include stack trace
ammarahm-ed Feb 20, 2026
cd909f6
add safety checks
ammarahm-ed Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions test-app/runtime/src/main/cpp/runtime/console/Console.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,27 @@ std::string transformJSObject(napi_env env, napi_value object) {

// Check if the object has a toString method
napi_has_named_property(env, object, "toString", &hasToString);

if (hasToString) {
napi_get_named_property(env, object, "toString", &toStringFunc);
if (napi_util::is_of_type(env, toStringFunc, napi_function)) {
napi_value result;
napi_call_function(env, object, toStringFunc, 0, nullptr, &result);
auto value = ArgConverter::ConvertToString(env, result);

bool is_error = false;
napi_is_error(env, object, &is_error);
if (is_error) {
napi_value stack;
napi_status status = napi_get_named_property(env, object, "stack", &stack);
if (status == napi_ok && !napi_util::is_null_or_undefined(env, stack)) {
auto stack_value = ArgConverter::ConvertToString(env, stack);
if (!stack_value.empty() && value.find(stack_value) == std::string::npos) {
value += "\n" + stack_value;
}
}
}

auto hasCustomToStringImplementation = value.find("[object Object]") == std::string::npos;
if (hasCustomToStringImplementation) return value;
}
Expand Down